Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Don't use turf icons for abilities #2215

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1224
Original PR: tgstation/tgstation#81720

About The Pull Request

Fixes wall-nerds/wallening#100
Replaces a couple of instances of abilities using the icons of walls or floors with different, somewhat more descriptive icons.

I will be honest I do not understand why two of these were even using iron walls as an icon.
Both of these instances were cases of "I want to surround something" so I have replaced them with this icon:
image

I have also replaced the "freeze floors" ability icon with the ice cube icon, rather than a 32x32 ice floor icon.
image

I removed a bunch of old copies of goggles items from the robot-items dmi and made them just reference the corresponding item sprites that they were copies of, because they were out of date with the items and using deprecated sprites. X-Ray now just looks like the red sam fisher goggles instead of a caution sign (not that it is obtainable in game).

Oh also I added a tooltip to Ice Demon afterimages because it didn't have one.

Why It's Good For The Game

The previous icons don't even look like anything.

Changelog

🆑 Jacquerel
image: Bubblegum Hallucination Surround Charge, Wendigo Shockwave Scream, and Ice Demon Floor Freeze all have more appropriate action icons.
qol: Adds a tooltip to Ice Demon Afterimages ability.
image: Cyborg view items now use the same sprites as their corresponding goggles instead of old versions of those sprites.
/:cl:

* Don't use turf icons for abilities (#81720)

## About The Pull Request

Fixes wall-nerds/wallening#100
Replaces a couple of instances of abilities using the icons of walls or
floors with different, somewhat more descriptive icons.

I will be honest I do not understand why two of these were even using
iron walls as an icon.
Both of these instances were cases of "I want to surround something" so
I have replaced them with this icon:

![image](https://github.com/tgstation/tgstation/assets/7483112/264da818-5c33-4093-b993-45ee1b06c24f)

I have also replaced the "freeze floors" ability icon with the ice cube
icon, rather than a 32x32 ice floor icon.

![image](https://github.com/tgstation/tgstation/assets/7483112/524af0ac-4128-4bd3-a3f0-f82583f6cbcb)

I removed a bunch of old copies of goggles items from the `robot-items`
dmi and made them just reference the corresponding item sprites that
they were copies of, because they were out of date with the items and
using deprecated sprites. X-Ray now just looks like the red sam fisher
goggles instead of a caution sign (not that it is obtainable in game).

Oh also I added a tooltip to Ice Demon afterimages because it didn't
have one.

## Why It's Good For The Game

The previous icons don't even look like anything.

## Changelog

:cl:
image: Bubblegum Hallucination Surround Charge, Wendigo Shockwave
Scream, and Ice Demon Floor Freeze all have more appropriate action
icons.
qol: Adds a tooltip to Ice Demon Afterimages ability.
image: Cyborg view items now use the same sprites as their corresponding
goggles instead of old versions of those sprites.
/:cl:

* Don't use turf icons for abilities

---------

Co-authored-by: Jacquerel <[email protected]>
@Iajret Iajret merged commit e27bc2c into master Mar 2, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1224 branch March 2, 2024 19:18
AnywayFarus added a commit that referenced this pull request Mar 2, 2024
Iajret pushed a commit that referenced this pull request Apr 28, 2024
…send you to the template area upon loading (#2215)

* Lazy load templates now have a prompt for whether or not to send you to the template area upon loading (#82902)

## About The Pull Request

Generating a lazy load template map now gives you a choice for whether
or not you want to be ghosted/teleported to the template you are
loading.
## Why It's Good For The Game

This has always annoyed me, especially when testing stuff related to the
nukie base (since it needs to be manually loaded before creating a nukie
team to avoid runtime spam). It might be a minor gripe, but I don't
think it should be forced.
## Changelog
:cl: Rhials
admin: Lazy loading map templates now gives you the option to not
ghost/teleport to the loaded area upon completion.
/:cl:

* Lazy load templates now have a prompt for whether or not to send you to the template area upon loading

---------

Co-authored-by: Rhials <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 29, 2024
…send you to the template area upon loading (#2215) (#3093)

* Lazy load templates now have a prompt for whether or not to send you to the template area upon loading (#82902)

## About The Pull Request

Generating a lazy load template map now gives you a choice for whether
or not you want to be ghosted/teleported to the template you are
loading.
## Why It's Good For The Game

This has always annoyed me, especially when testing stuff related to the
nukie base (since it needs to be manually loaded before creating a nukie
team to avoid runtime spam). It might be a minor gripe, but I don't
think it should be forced.
## Changelog
:cl: Rhials
admin: Lazy loading map templates now gives you the option to not
ghost/teleport to the loaded area upon completion.
/:cl:

* Lazy load templates now have a prompt for whether or not to send you to the template area upon loading

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Rhials <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird uses of sprites
3 participants